Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(frontend): rename "swap" to "convert" #3779

Merged
merged 2 commits into from
Nov 29, 2024
Merged

feat(frontend): rename "swap" to "convert" #3779

merged 2 commits into from
Nov 29, 2024

Conversation

DenysKarmazynDFINITY
Copy link
Contributor

Motivation

The renaming is requested by the design and product team:

It turns out that the word ‘Swap’ might be misleading in our context of ChainFusion conversion. After discussing with 
Stefan, we agreed to stick with the ‘Convert’ naming until we find a better unique one (it's a marketing question tbh).
Can we please update the wording in the modal title and in the ‘Swap fee’ line?”

@DenysKarmazynDFINITY DenysKarmazynDFINITY requested a review from a team as a code owner November 28, 2024 13:58
AntonioVentilii
AntonioVentilii approved these changes Nov 28, 2024
View reviewed changes
Copy link
Collaborator

@AntonioVentilii AntonioVentilii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM tks!

AntonioVentilii
AntonioVentilii reviewed Nov 28, 2024
View reviewed changes
src/frontend/src/lib/i18n/en.json Outdated
@@ -537,7 +537,7 @@
"estimated_inter_network": "Estimated Inter-network Fee",
"estimated_eth": "Estimated Ethereum Fee",
"max_fee_eth": "Max fee <small>(likely in &lt; 30 seconds)</small>:",
"convert_fee": "Swap fee",
"convert_fee": "Convert fee",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe "Conversion fee"? Or does it sound better "Convert fee"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Conversion fee" is better, thanks for the tip!

@DenysKarmazynDFINITY DenysKarmazynDFINITY merged commit b8e31b0 into main Nov 29, 2024
18 checks passed
@DenysKarmazynDFINITY DenysKarmazynDFINITY deleted the feat(frontend)/rename-swap branch November 29, 2024 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AntonioVentilii AntonioVentilii AntonioVentilii approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DenysKarmazynDFINITY @AntonioVentilii