fix(frontend): correct price for BURN token #3745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Motivation IcrcData from the json is wrongly mapped with an exchangeCoinId hardcoded to internet-computer. This is wrong and causes the fallback logic of exchange balance to default to the ICP price. # Changes remove hardcoded value --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
AntonioVentilii
changed the title
…ledger canister id (#3744) # Motivation The original intention of the list ICRC_TOKENS_LEDGER_CANISTER_IDS implied by its only usage in enabledIcrcTokensNoCk was to filter out Ck canister ids. By adding additional ICRC tokens to ICRC_TOKENS and the following mapping of the canister ids to the list, causes a bug: There will be no usd exchange rates for these tokens as they are not included in the enabledIcrcTokensNoCk store. This bug, combined with the wrong fallback logic corrected in #3740 led to a false usd value of additional ICRC tokens. # Changes Rename the variable ICRC_TOKENS_LEDGER_CANISTER_IDS to reflect its only usage of holding CK token ledger canister ids Fix the content of this list to include CK tokens. # Tests  --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
# Motivation Bumping version for hotfix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The commits in this branch were already reviewed and are used for the hotfix released with
v0.9.5Reviews: