Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(IDX): replace PAT with GitHub App #3689

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

cgundy
Copy link
Member

@cgundy cgundy commented Nov 20, 2024

Motivation

This is part of a larger effort to replace PATs generated my service accounts with GitHub Apps.

Changes

No functional changes.

Tests

No tests run, but has been successfully installed in other repos.

@cgundy cgundy marked this pull request as ready for review November 20, 2024 13:53
@cgundy cgundy requested a review from a team as a code owner November 20, 2024 13:53
Copy link
Collaborator

@AntonioVentilii AntonioVentilii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cgundy thank you for this! Do you think it makes sense that it becomes an action instead of a step in each workflow? Just to avoid repetition of code

@cgundy
Copy link
Member Author

cgundy commented Nov 20, 2024

@AntonioVentilii do you mean like a composite action? I'm not sure I understand.

@AntonioVentilii
Copy link
Collaborator

@cgundy yes, correct! a composite. I see you changed it in a few CIs. I am just asking if it is possible at all eheh!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants