feat(frontend): new modal design #3171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…al-design # Conflicts: # src/frontend/src/lib/styles/global/gix.scss
peterpeterparker
added a commit
that referenced
this pull request
Oct 29, 2024
# Motivation We need a new background colors for the modals #3171. # Changes - Init color #f8f9fa as discussed with Artem
|
@peterpeterparker completely agree on the E2E tests + mobile screenshots. I am tagging @Stefan-Berger-DFINITY |
AntonioVentilii-DFINITY
approved these changes
Oct 29, 2024
peterpeterparker
added a commit
that referenced
this pull request
Oct 29, 2024
# Motivation Fix a side effect of the new modal design #3171. The banner for the dapp modal should be outside of the card. # Screenshots Incorrect: <img width="1536" alt="Capture d’écran 2024-10-29 à 13 58 57" src="https://github.com/user-attachments/assets/c0c0fab2-c76a-4331-90ca-a401ec0cb43f"> After: <img width="1536" alt="Capture d’écran 2024-10-29 à 13 58 40" src="https://github.com/user-attachments/assets/15e277bc-afec-4445-bc15-29f0b516ec58"> <img width="1536" alt="Capture d’écran 2024-10-29 à 13 58 46" src="https://github.com/user-attachments/assets/dd129e50-b1f0-4756-9a93-1bb19e786444">
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
New design for the modal as in Figma.
TODO
We need E2E tests that take screenshots of the modals. It was incredibly painful to test each modal repeatedly. I ended up taking screenshots for this PR about 20 times.
Leftovers
It was already too much work. I'll have a look to the WalletConnect modal afterwards.
Changes
Screenshots