Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style(frontend): fix wallet connect qr btn style #3138

Merged
merged 3 commits into from
Oct 28, 2024

Conversation

loki344
Copy link
Collaborator

@loki344 loki344 commented Oct 25, 2024

Motivation

The text color of the wallet connect modal button is not readable. For now, in coordination with the design team we display a primary button.

Changes

Use btn component for Wallet connect modal QR code

Tests

Text marked so we see that it is there:
image
No text showing:
image

image

@loki344 loki344 marked this pull request as ready for review October 25, 2024 16:05
@loki344 loki344 requested a review from a team as a code owner October 25, 2024 16:05
Copy link
Contributor

@AntonioVentilii-DFINITY AntonioVentilii-DFINITY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM tks!

@loki344 loki344 enabled auto-merge (squash) October 28, 2024 08:36
@loki344 loki344 merged commit 30cfccd into main Oct 28, 2024
10 checks passed
@loki344 loki344 deleted the style(frontend)/fix-wallet-connect-text-color branch October 28, 2024 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants