reenable tests and adjust cycles in rust threshold Schnorr #1015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
altkdf
changed the title
fspreiss
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pocket IC now supports threshold BIP340 and Ed25519, so the tests can be (re)enabled.
Pocket IC has two (implementation) limitations though:
dfx_test_key, so we have to temporarily use another key name, which is not very important though.This PR also adjusts cycles attached to the
sign_with_schnorrcall. The adjusted amount of cycles is sufficient to make a call to a 34-node subnet, which is currently the case on mainnet for the production key. Note that overpaid cycles are reimbursed to the caller, which would be relevant for calls to smaller subnets like currently the case for the production test key.Closes CRP-2585.
Closes CRP-2604.