Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add AllowedViewers variant to LogVisibility enum #512

Merged
merged 2 commits into from
Sep 6, 2024
Merged

feat: add AllowedViewers variant to LogVisibility enum #512

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1a1466d
log_visibility v2
maksymar Aug 27, 2024
5903585
Merge branch 'main' into maksym/log-visibility-v2
maksymar Sep 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/ic-cdk/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [unreleased]

* Add `AllowedViewers` to `LogVisibility` enum.

## [0.16.0] - 2024-08-27

### Changed
Expand Down
3 changes: 3 additions & 0 deletions src/ic-cdk/src/api/management_canister/main/types.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,9 @@ pub enum LogVisibility {
#[serde(rename = "public")]
/// Everyone is allowed to access the canister's logs.
Public,
#[serde(rename = "allowed_viewers")]
/// Canister logs are visible to a set of principals.
AllowedViewers(Vec<Principal>),
}

/// Canister settings.
Expand Down