chore: CI for release candid-extractor #427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericswanson-dfinity
requested changes
Sep 19, 2023
There was a problem hiding this comment.
I think it would be better to build with releases on specific versioned runners, rather than the -latest variants.
For one, when GitHub updates these, they typically roll out changes gradually. So for example, when macos-latest was transitioning from macos-11 to macos-12, maybe 10% of runs specifying macos-latest would use macos-12 runners, while the remainder used macos-11.
For ubuntu, I've suggested ubuntu-20.04 rather than ubuntu-22.04 to avoid linker errors with glibc. This is why we build dfx with ubuntu-20.04 as well.
ericswanson-dfinity
approved these changes
Sep 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a workflow to release
candid-extractorthat supportcargo binstall.This release is a successful run of the new workflow.
How Has This Been Tested?
Check the release above.
cargo binstall candid-extractorwhich should directly download the prebuilt binary without compilation.Checklist: