Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: target_canister to be handled only for method install_chunked_code #957

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

peterpeterparker
Copy link
Member

Description

Follow-up of #954.

I read the spec again which explicitely mention that:

  • First it's the target_canister that should be potentially handled (before canister_id)
  • And target_canister is only to be considered for the method install_chunked_code

Therefore this PR refines getManagementCanister to be closer to the spec.

Notes

No entry in CHANGELOG given that previous feature is not released yet anyway.

Changes:

  • Invert logic order in getManagementCanister (target_canister before canister_id)
  • Add checks on method install_chunked_code
  • Add more test and move common test data in a describe

@peterpeterparker peterpeterparker requested a review from a team as a code owner November 27, 2024 10:57
Copy link
Contributor

size-limit report 📦

Path Size
@dfinity/agent 87.15 KB (+0.02% 🔺)
@dfinity/candid 13.58 KB (0%)
@dfinity/principal 4.97 KB (0%)
@dfinity/auth-client 61 KB (0%)
@dfinity/assets 81.92 KB (+0.01% 🔺)
@dfinity/identity 58.15 KB (0%)
@dfinity/identity-secp256k1 132.19 KB (+0.01% 🔺)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant