Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: trap and throw handling in v3 sync call #940

Merged
merged 4 commits into from
Oct 11, 2024
Merged

Conversation

krpeacock
Copy link
Contributor

@krpeacock krpeacock commented Oct 11, 2024

Description

Reported after observing that reject_code and reject_message were missing in the error message in cases where v3 sync calls were used. Corrects the flow to pull this information out of the certificate and provides them to the error

Also adds them as public fields on the error object

Fixes # (issue)

How Has This Been Tested?

New e2e tests handling Trap and Throw cases

Checklist:

  • My changes follow the guidelines in CONTRIBUTING.md.
  • The title of this PR complies with Conventional Commits.
  • I have edited the CHANGELOG accordingly.
  • I have made corresponding changes to the documentation.

@krpeacock krpeacock requested a review from a team as a code owner October 11, 2024 19:37
Copy link
Contributor

github-actions bot commented Oct 11, 2024

size-limit report 📦

Path Size
@dfinity/agent 86.02 KB (+0.07% 🔺)
@dfinity/candid 13.58 KB (0%)
@dfinity/principal 4.97 KB (0%)
@dfinity/auth-client 60.36 KB (0%)
@dfinity/assets 81.08 KB (+0.09% 🔺)
@dfinity/identity 57.56 KB (0%)
@dfinity/identity-secp256k1 131.22 KB (+0.06% 🔺)

@krpeacock krpeacock enabled auto-merge (squash) October 11, 2024 21:28
@krpeacock krpeacock merged commit c73e4a9 into main Oct 11, 2024
16 checks passed
@krpeacock krpeacock deleted the kai/undefined-error branch October 11, 2024 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants