Adding Styleguide Entry helper. #28
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cumentation that does not directly correlate to an element.
| @@ -15,5 +15,15 @@ def styleguide_block(section, &block) | |||
| content = capture(&block) | |||
| render 'kss/shared/styleguide_block', :section => @section, :example_html => content | |||
| end | |||
|
|
|||
| def styleguide_entry(section) | |||
| raise ArgumentError, 'Missing Entry' unless section | |||
There was a problem hiding this comment.
We can remove this ArgumentError since it'll be raised if it's not present when styleguide_entry is called.
|
I've made the changes you suggested, it also adds a requirement for ostruct (and I wasn't really sure where to add that). Let me know how that looks! |
|
It looks like section.section returns a NoMethodError in cases where a section is not found, and you can't set section on @section instances in the helper. I agree creating a struct feels like a bit much, but not sure what other route to take? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In cases where there is CSS / SCSS documentation that does not directly correlate to an element, it would be nice to have a helper to simply output the text of the documentation like:
= styleguide_entry '1.1'