"Get latest changes from dart-archive/ts2dart master #1" #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and more readable test cases.
identifiers on new expressions.
identifiers on new expressions.
identifiers on new expressions.
identifiers on new expressions.
Reviewers: alexeagle, mhevery Reviewed By: alexeagle, mhevery Subscribers: typescript-eng Differential Revision: https://reviews.angular.io/D79
Summary: Otherwise this task could run without its prerequisites. feat: handle lib.d.ts definitions from tsconfig When configured through tsconfig, instead of a custom compiler host, the fileName for default library definitions is the absolute path of the library. This change explicitly uses the compiler host's information for the location of lib.d.ts. Reviewers: alexeagle, mhevery Reviewed By: mhevery Subscribers: typescript-eng Differential Revision: https://reviews.angular.io/D80
Summary: This allows marking an expression as const without JavaScript code for the `CONST_EXPR` call. `CONST_EXPR` is not recognised by simple bundlers such as rollup as a side-effect free function, which causes unnecessary symbols to be retained in the binary. Avoiding `CONST_EXPR` and instead using `/* @ts2dart_const */ (...)` should thus allow Angular 2 to reduce its binary size. Reviewers: mhevery, alexeagle Reviewed By: alexeagle Subscribers: typescript-eng Differential Revision: https://reviews.angular.io/D83
Summary: ... to allow better results in rollup. Reviewers: mhevery, alexeagle Reviewed By: alexeagle Subscribers: typescript-eng Differential Revision: https://reviews.angular.io/D85
Reviewers: alexeagle, mhevery Reviewed By: mhevery Subscribers: typescript-eng Differential Revision: https://reviews.angular.io/D86
Summary: Installing `test` version 0.12.8 fails on Travis, but works locally. Version 0.12.13 works in both locations. This does not really make sense - `pub get` should be deterministic, and should also be able to get the older version of the test package, but whatever. Reviewers: vikerman Reviewed By: vikerman Subscribers: typescript-eng Differential Revision: https://reviews.angular.io/D87
Summary: This is useful when the feature branch tracks a different upstream branch from master, which happens e.g. when you `git push --set-upstream feature feature`, which in turn is useful to have Travis test a change. Reviewers: alexeagle Subscribers: typescript-eng Differential Revision: https://reviews.angular.io/D88
Summary: In Dart, all default values have to be const. Reviewers: mhevery Reviewed By: mhevery Subscribers: typescript-eng Differential Revision: https://reviews.angular.io/D89
Summary: This fixes the bug where all code in const marked classes was treated as const. Reviewers: mhevery Reviewed By: mhevery Subscribers: typescript-eng Differential Revision: https://reviews.angular.io/D90
fix: Future.{value,error} are named constructors, not statics
When using TypeScript's path support and driving ts2dart using a tsconfig.json, path resolution yields absolute paths. This change resolves the well known paths using TypeScript's own module resolver, and then looks up absolute file paths against that, greatly simplifying the path handling logic (woohoo!). Reviewers: alexeagle Subscribers: typescript-eng Differential Revision: https://reviews.angular.io/D94
The last entry in the array is the code under test for multi-file test cases.
These are used to mark object literals as providers that need to be translated to `new Provider(...)` in Dart.
TypeScript resolves files to absolute path names only when they are discovered through an import. To avoid that mess, resolve all paths before proceeding. Also port the remaining e2e test to use a tsconfig.json.
Summary: Previously only worked for functions. Fixes dart-archive#282. Reviewers: tbosch Reviewed By: tbosch Subscribers: typescript-eng Differential Revision: https://reviews.angular.io/D100
…-archive#372) * Add ability to install globally and execute as command line app * reformat code * add showHelp method and upgrade test to 0.12.15+3 in pubspec.yaml * correct typo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jacob314#1