Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: tela de registro #604

Merged
merged 28 commits into from
Sep 9, 2024
Merged

Feat: tela de registro #604

merged 28 commits into from
Sep 9, 2024

Conversation

lfelipessilva
Copy link
Contributor

@lfelipessilva lfelipessilva commented Sep 2, 2024 •
edited
Loading

Closes #597

Feature
  • tela de registro
  • inputs de texto
Visual evidences 🖼️

desktop
mobile

Checklist
  • Issue linked
  • Build working correctly
  • Tests created

@lfelipessilva lfelipessilva marked this pull request as ready for review September 2, 2024 18:30
@lfelipessilva lfelipessilva changed the base branch from issue-597 to master September 2, 2024 18:39
@lfelipessilva lfelipessilva requested review from a team as code owners September 2, 2024 18:39
@juliaam
Copy link
Contributor

juliaam commented Sep 2, 2024

Tem alguns testes unitários com erro, consegue dar uma olhada nisso?

@PiluVitu PiluVitu requested review from PiluVitu and removed request for PiluVitu September 2, 2024 20:37
Alecell
Alecell suggested changes Sep 3, 2024
View reviewed changes
Copy link
Contributor

@Alecell Alecell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Iae Felipe, man seu códito ta muito bom e vi que vc seguiu bem os padrões do time e deu um super gás nele!

Só queria saber, como PR é bem grande e tem umas coisas bem grandes pra gente ajustar, vc tem um tempinho que a gente consiga parear pra passarmos pelo seu PR?

juliaam
juliaam requested changes Sep 3, 2024
View reviewed changes
Copy link
Contributor

@juliaam juliaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tive a impressão dos elementos da página estarem um pouco pequenos, dei uma checada com um zoom maior e com 125% ou 150% que pareceu estar proporcional ao tamanho da home, dá uma olhada

home 100%

image

register 100%

image

125%

image

150%

image

Dito essas coisas, esse pr está muito bem feito, parabéns, você é bom!

src/App.tsx Outdated Show resolved Hide resolved
src/pages/register/components/Form/Form.tsx Outdated Show resolved Hide resolved
src/pages/register/components/Form/images/octo.svg Outdated Show resolved Hide resolved
src/pages/register/components/MobileHero/images/octo.svg Outdated Show resolved Hide resolved
src/pages/register/register.tsx Outdated Show resolved Hide resolved
src/pages/register/components/Footer/Footer.module.scss Outdated Show resolved Hide resolved
src/pages/register/components/Footer/Footer.module.scss Outdated Show resolved Hide resolved
src/pages/register/components/MobileHero/Hero.module.scss Outdated Show resolved Hide resolved
src/pages/register/components/SignUpPromotion/SignUpPromotion.module.scss Outdated Show resolved Hide resolved
src/pages/register/components/SignUpPromotion/SignUpPromotion.module.scss Outdated Show resolved Hide resolved
DominMFD
DominMFD requested changes Sep 3, 2024
View reviewed changes
Copy link
Contributor

@DominMFD DominMFD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cara, vc amassou muito, vc é muito bom

src/pages/register/components/MobileHero/Hero.tsx Outdated Show resolved Hide resolved
src/pages/register/components/SocialLogin/SocialLogin.tsx Outdated Show resolved Hide resolved
src/pages/register/components/Footer/Footer.tsx Outdated Show resolved Hide resolved
Luiginicoletti
Luiginicoletti approved these changes Sep 4, 2024
View reviewed changes
Copy link
Member

@Luiginicoletti Luiginicoletti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Alecell
Alecell suggested changes Sep 5, 2024
View reviewed changes
Copy link
Contributor

@Alecell Alecell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

O componente TextInput tem alguns problemas fortes que vamos precisar ajustar, mas não precisamos ajustar isso nesse PR! O componente é extremamente complicado de fazer e por hora esse ta atendendo a necessidade então ta perfeito! Se quiser podemos falar sobre depois

src/pages/register/components/MobileHero/Hero.module.scss Outdated Show resolved Hide resolved
src/pages/register/components/DesktopHero/Hero.module.scss Outdated Show resolved Hide resolved
src/pages/register/components/DesktopHero/Hero.module.scss Outdated Show resolved Hide resolved
src/pages/register/components/DesktopHero/Hero.module.scss Show resolved Hide resolved
src/pages/register/components/DesktopHero/Hero.module.scss Show resolved Hide resolved
src/pages/register/components/SocialLogin/SocialLogin.tsx Outdated Show resolved Hide resolved
src/pages/register/register.module.scss Outdated Show resolved Hide resolved
src/pages/register/components/MobileHero/Hero.tsx Outdated Show resolved Hide resolved
src/pages/register/components/MobileHero/Hero.tsx Outdated Show resolved Hide resolved
src/pages/register/components/MobileHero/Hero.module.scss Show resolved Hide resolved
juliaam
juliaam requested changes Sep 5, 2024
View reviewed changes
Copy link
Contributor

@juliaam juliaam left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

acabei não vendo no primeiro review, mas essa parte de "Or sign up with" está um pouco diferente. No seu PR tá faltando o divider e o texto está diferente, consegue arrumar?

image

image

src/pages/register/components/Form/images/octo.svg Outdated Show resolved Hide resolved
@juliaam
Copy link
Contributor

juliaam commented Sep 5, 2024

e atualiza a branch! 😄

Alecell
Alecell suggested changes Sep 6, 2024
View reviewed changes
src/pages/register/register.module.scss Outdated Show resolved Hide resolved
@Alecell Alecell merged commit 1df7b68 into devhatt:master Sep 9, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliaam juliaam juliaam approved these changes

@Alecell Alecell Alecell approved these changes

@JpBurgarelli JpBurgarelli Awaiting requested review from JpBurgarelli JpBurgarelli is a code owner automatically assigned from devhatt/hatts

@Frompaje Frompaje Awaiting requested review from Frompaje Frompaje is a code owner automatically assigned from devhatt/hatts

@PiluVitu PiluVitu Awaiting requested review from PiluVitu

@DominMFD DominMFD Awaiting requested review from DominMFD

@Luiginicoletti Luiginicoletti Awaiting requested review from Luiginicoletti

Assignees

@lfelipessilva lfelipessilva

Labels
None yet
Projects
Octopost Frontend
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tela de registro sem a integração
5 participants
@lfelipessilva @juliaam @Alecell @Luiginicoletti @DominMFD