Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: revert "Fix: pin stow to version 2.3.1"; don't stow absolute symbolic links #173

Merged
merged 2 commits into from
May 17, 2024

Conversation

AObuchow
Copy link
Contributor

This PR aims to resolve eclipse-che/che#22957.

It makes 2 changes:

Testing

I've created the following devfile repository to test the image built from this PR in Che.

To test, I ensured that podman worked as expected when running podman info and podman build . I also ensured that all bianries which no longer have symbolic links pointing to /home/user/ are still on $PATH. These include: mvn, gradle, jbang, java, kubectl-krew, kubectl-ctx, kubectl-ns & podman.

~ $ which mvn
/home/tooling/.sdkman/candidates/maven/current/bin/mvn
~ $ which gradle
/home/tooling/.sdkman/candidates/gradle/current/bin/gradle
~ $ which java
/home/tooling/.sdkman/candidates/java/current/bin/java
~ $ which jbang
/home/tooling/.sdkman/candidates/jbang/current/bin/jbang
~ $ which podman
/home/tooling/.local/bin/podman
~ $ which kubectl-krew 
/home/tooling/.krew/bin/kubectl-krew
~ $ which kubectl-ns
/home/tooling/.krew/bin/kubectl-ns
~ $ which kubectl-ctx
/home/tooling/.krew/bin/kubectl-ctx

image

This reverts commit 8627963.

Signed-off-by: Andrew Obuchowicz <[email protected]>
@AObuchow AObuchow force-pushed the stow-ignore-absolute-sym-links branch from fb7d865 to 00a8417 Compare May 16, 2024 19:57
Copy link
Collaborator

@svor svor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
Thank you @AObuchow for providing the sample for testing
screenshot-che-dogfooding apps che-dev x6e0 p1 openshiftapps com-2024 05 17-16_39_27

Copy link

openshift-ci bot commented May 17, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: AObuchow, svor

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@AObuchow
Copy link
Contributor Author

@svor thank you for the prompt review :)

@AObuchow AObuchow merged commit 045b16e into devfile:main May 17, 2024
2 checks passed
@AObuchow AObuchow deleted the stow-ignore-absolute-sym-links branch May 17, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

stow command is failing in UDI build
2 participants