remove mixed enum from devContainer.base.schema.json #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mixed enums are not widely supported by generators.
chrmarti
requested changes
Apr 18, 2023
| ], | ||
| "description": "Indicates whether a GPU is required. The string \"optional\" indicates that a GPU is optional. An object value can be used to configure more detailed requirements." | ||
| "type": "boolean", | ||
| "const" : true, |
There was a problem hiding this comment.
Is false still a valid value with this?
| "description": "Indicates whether a GPU is required. The string \"optional\" indicates that a GPU is optional. An object value can be used to configure more detailed requirements." | ||
| "type": "boolean", | ||
| "const" : true, | ||
| "description": "Indicates a GPU is required." |
There was a problem hiding this comment.
The description can be shown in editors. I suggest we copy the original description to both descriptions here, so the user will always get the full description for all 3 cases.
mtrackeros
approved these changes
Mar 23, 2024
mtrackeros
approved these changes
Mar 23, 2024
|
꧁꫞包̫义̫奇̫꫞꧂
|
Abhi7739309
reviewed
Aug 2, 2024
| @@ -723,4 +721,4 @@ | |||
| } | |||
| ], | |||
| "unevaluatedProperties": false | |||
| } | |||
Graysonbarton
approved these changes
Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mixed enums are not widely supported by generators.
In particular both the rust and python generators don't work.