Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance Template metadata #875

Merged
merged 4 commits into from
Aug 22, 2024
Merged

Conversation

joshspicer
Copy link
Member

Related: devcontainers/spec#484

  • Updates Template interface
  • Includes array of file names on published Template metadata (potentially useful for consuming tools)
  • When an optionalPaths directory entry implies only a single file is optional, automatically resolve that full file name on the metadata. Useful for consuming tools to better highlight what file is optional
  • Fixed code that appends featureIds to Template metadata (now uses getRef(..) function to cover edge cases)
  • Add new test case to validate the above

@joshspicer joshspicer requested a review from a team as a code owner August 21, 2024 18:37
Copy link
Member

@samruddhikhandale samruddhikhandale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@joshspicer joshspicer self-assigned this Aug 22, 2024
@joshspicer
Copy link
Member Author

Validated that the optionalPaths single-file resolution is working as-expected e2e:
image

@joshspicer joshspicer merged commit b01622e into main Aug 22, 2024
37 checks passed
@joshspicer joshspicer deleted the joshspicer/capture-more-template-data branch August 22, 2024 19:56
@joshspicer joshspicer mentioned this pull request Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants