Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --omit-paths flag to templates apply #868

Merged
merged 7 commits into from
Aug 12, 2024
Merged

Conversation

joshspicer
Copy link
Member

@joshspicer joshspicer commented Aug 1, 2024

Related: devcontainers/spec#484, microsoft/vscode-remote-release#10095

The templates apply command now exposes a flag --omit-paths. Following the same file/folder syntax as shown in devcontainers/spec#484, the provided array of paths will not be extracts from the tarball when applying a Template.

Expanded upon getBlob()'s existing filtering logic.

@joshspicer joshspicer requested a review from a team as a code owner August 1, 2024 21:47
@joshspicer joshspicer changed the title Add --omit-paths flag to templates apply Add --omit-path flag to templates apply Aug 1, 2024
@joshspicer joshspicer changed the title Add --omit-path flag to templates apply Add --omit-paths flag to templates apply Aug 1, 2024
Copy link
Member

@samruddhikhandale samruddhikhandale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@joshspicer
Copy link
Member Author

joshspicer commented Aug 12, 2024

Manual integration test on MacOS ✅ (see directory tree is missing .github)
image

@joshspicer
Copy link
Member Author

Manual integration test on Windows ✅ (see directory tree is missing .github)
image

@joshspicer joshspicer merged commit fcefe52 into main Aug 12, 2024
37 checks passed
@joshspicer joshspicer deleted the joshspicer/omit-paths branch August 12, 2024 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants