Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: api module 에서 presentation 관심사 제외 #177

Closed
wants to merge 14 commits into from
Closed

refactor: api module 에서 presentation 관심사 제외 #177

wants to merge 14 commits into from

Conversation

junhaesung
Copy link
Member

@junhaesung junhaesung commented Aug 28, 2022 •
edited
Loading

📌Linked Issues

✏Change Details

  • client 가 사용하는 dto 에서 서버 로직에서 사용하는 vo 로 변환하는 단계 추가
  • api module 의 dto, swagger 등 표현계층 관심사 코드를 web module 로 이동

💬Comment

📑References

✅Check List

  • 추가한 기능에 대한 테스트는 모두 완료하셨나요?
  • 코드 정렬(Ctrl + Alt + L), 불필요한 코드나 오타는 없는지 확인하셨나요?

@sonarcloud
Copy link

sonarcloud bot commented Aug 30, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 2 Security Hotspots
Code Smell A 0 Code Smells

35.4% 35.4% Coverage
0.0% 0.0% Duplication

@junhaesung junhaesung closed this Dec 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IW-MOON IW-MOON IW-MOON approved these changes

@nature1216 nature1216 Awaiting requested review from nature1216 nature1216 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

api 모듈에서 presentation 계층 관련 코드 제거
2 participants
@junhaesung @IW-MOON