feat: event for a resolved package nv #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsherret
commented
Jul 13, 2024
…d, but actually optional because an ancestor was optional
dsherret
commented
Jul 13, 2024
| @@ -903,36 +904,39 @@ pub struct SnapshotFromLockfileParams<'a> { | |||
| /// [`IncompleteSnapshot`] instance that's passed as the first argument for this | |||
| /// function. | |||
| #[allow(clippy::needless_lifetimes)] // clippy bug | |||
| pub async fn snapshot_from_lockfile<'a>( | |||
| params: SnapshotFromLockfileParams<'a>, | |||
| pub async fn snapshot_from_lockfile<'a, TNpmRegistryApi: NpmRegistryApi>( | |||
There was a problem hiding this comment.
We still need events when resolving one of these from a lockfile, but we can add that in a separate PR.
dsherret
commented
Jul 13, 2024
There was a problem hiding this comment.
Extracted out from registry.rs. No changes other than pub(crate) on matches_os_or_cpu_vec
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can use this to immediately start downloading package tarballs and setting up the node_modules directory.
We can't send the package id or folder id here because we don't know that until the end of resolution, but that's fine because this allows us to start downloading and extracting the tarball to the global cache as well as setting up the non-copy folder at
node_modules/.deno/<folder-id>/<package-name>/where<folder-id>is just the package nv (folder-id with an index of0). At the end we can then setup the copy folders.Closes #24