Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use latest tag version directly if version req is * #30

Merged
merged 1 commit into from
Sep 6, 2023

Conversation

await-ovo
Copy link
Contributor

for npm package await-o-test-pre-release-tag

$ npm view await-o-test-pre-release-tag
dist-tags:
alpha: 1.0.0-alpha.3   latest: 1.0.0-alpha.1  next: 3.0.0

if we run deno run -A --node-modules-dir npm:await-o-test-pre-release-tag it will install version 3.0.0:

$ ls node_modules/.deno
[email protected] node_modules

it should install version 1.0.0-alpha.1 as npm or yarn does.

Alternatively, if the package being installed has only one prerelease version, deno will throw an error:

Could not find npm package 'A' matching '*'.

Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@dsherret dsherret merged commit 2eb6eb2 into denoland:main Sep 6, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants