-
Notifications
You must be signed in to change notification settings - Fork 5.4k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: Update deno_npm to fix
deno install
with crossws (#25837)
Partially addresses #25648. This allows packages that use `crossws` to be installed with `deno install`. `crossws` specifies an optional peer dependency on `uWebSockets`, but `uWebSockets` is not on npm (it is used with `git:` or `github:` specifiers). Previously we would error on this, now we don't error on non-existent optional peer dependencies.
- Loading branch information
1 parent
74e294c
commit 1e261c9
Showing
7 changed files
with
37 additions
and
3 deletions.
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Empty file.
12 changes: 12 additions & 0 deletions
12
tests/registry/npm/@denotest/non-existent-optional-peer/1.0.0/package.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
{ | ||
"name": "@denotest/non-existent-optional-peer", | ||
"version": "1.0.0", | ||
"peerDependencies": { | ||
"uWebSockets.js": "*" | ||
}, | ||
"peerDependenciesMeta": { | ||
"uWebSockets.js": { | ||
"optional": true | ||
} | ||
} | ||
} |
11 changes: 11 additions & 0 deletions
11
tests/specs/install/non_existent_optional_peer/__test__.jsonc
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
// test imitates what crossws 0.2.4 has https://www.npmjs.com/package/crossws/v/0.2.4 | ||
// where uWebSockets.js is an optional peer dep, but doesn't exist on npm | ||
{ | ||
"tempDir": true, | ||
"steps": [ | ||
{ | ||
"args": "install", | ||
"output": "install.out" | ||
} | ||
] | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
[UNORDERED_START] | ||
Download http://localhost:4260/@denotest/non-existent-optional-peer | ||
Download http://localhost:4260/uWebSockets.js | ||
Download http://localhost:4260/@denotest/non-existent-optional-peer/1.0.0.tgz | ||
[UNORDERED_END] | ||
Initialize @denotest/[email protected] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
{ | ||
"dependencies": { | ||
"@denotest/non-existent-optional-peer": "1.0.0" | ||
} | ||
} |