Skip to content

Commit

Permalink
fix: Update deno_npm to fix deno install with crossws (#25837)
Browse files Browse the repository at this point in the history
Partially addresses #25648.

This allows packages that use `crossws` to be installed with `deno
install`. `crossws` specifies an optional peer dependency on
`uWebSockets`, but `uWebSockets` is not on npm (it is used with `git:`
or `github:` specifiers). Previously we would error on this, now we
don't error on non-existent optional peer dependencies.
  • Loading branch information
nathanwhit authored Sep 24, 2024
1 parent 74e294c commit 1e261c9
Show file tree
Hide file tree
Showing 7 changed files with 37 additions and 3 deletions.
4 changes: 2 additions & 2 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion cli/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ deno_doc = { version = "0.148.0", features = ["html", "syntect"] }
deno_graph = { version = "=0.82.1" }
deno_lint = { version = "=0.67.0", features = ["docs"] }
deno_lockfile.workspace = true
deno_npm = "=0.25.1"
deno_npm = "=0.25.2"
deno_package_json.workspace = true
deno_runtime = { workspace = true, features = ["include_js_files_for_snapshotting"] }
deno_semver.workspace = true
Expand Down
Empty file.
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
{
"name": "@denotest/non-existent-optional-peer",
"version": "1.0.0",
"peerDependencies": {
"uWebSockets.js": "*"
},
"peerDependenciesMeta": {
"uWebSockets.js": {
"optional": true
}
}
}
11 changes: 11 additions & 0 deletions tests/specs/install/non_existent_optional_peer/__test__.jsonc
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
// test imitates what crossws 0.2.4 has https://www.npmjs.com/package/crossws/v/0.2.4
// where uWebSockets.js is an optional peer dep, but doesn't exist on npm
{
"tempDir": true,
"steps": [
{
"args": "install",
"output": "install.out"
}
]
}
6 changes: 6 additions & 0 deletions tests/specs/install/non_existent_optional_peer/install.out
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
[UNORDERED_START]
Download http://localhost:4260/@denotest/non-existent-optional-peer
Download http://localhost:4260/uWebSockets.js
Download http://localhost:4260/@denotest/non-existent-optional-peer/1.0.0.tgz
[UNORDERED_END]
Initialize @denotest/[email protected]
5 changes: 5 additions & 0 deletions tests/specs/install/non_existent_optional_peer/package.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
{
"dependencies": {
"@denotest/non-existent-optional-peer": "1.0.0"
}
}

0 comments on commit 1e261c9

Please sign in to comment.