Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correctly recognize existing delta tables using the transaction log #3005

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

stretchadito
Copy link
Contributor

Description

In logstore.is_delta_table_location(), if a checkpoint file is the earliest/first file in a table's transaction log, the table should be positively identified as a delta table. (Currently, it only recognizes delta tables for which a commit json is the first file in the transaction log)

Related Issue(s)

Copy link

codecov bot commented Nov 19, 2024

Codecov Report

Attention: Patch coverage is 89.83051% with 6 lines in your changes missing coverage. Please review.

Project coverage is 72.41%. Comparing base (d4f18b3) to head (10d686d).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/core/src/logstore/mod.rs 89.83% 0 Missing and 6 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3005      +/-   ##
==========================================
+ Coverage   72.35%   72.41%   +0.05%     
==========================================
  Files         128      128              
  Lines       40467    40525      +58     
  Branches    40467    40525      +58     
==========================================
+ Hits        29281    29346      +65     
+ Misses       9308     9303       -5     
+ Partials     1878     1876       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@rtyler rtyler added this pull request to the merge queue Nov 20, 2024
Merged via the queue into delta-io:main with commit c1c42b6 Nov 20, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
binding/rust Issues for the Rust crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Log store may erroneously consider valid delta tables to be nonexistent
2 participants