fix: cache credential resolution with the AWS credential provider #2987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2987 +/- ##
==========================================
+ Coverage 72.27% 72.33% +0.06%
==========================================
Files 128 128
Lines 40341 40420 +79
Branches 40341 40420 +79
==========================================
+ Hits 29155 29237 +82
+ Misses 9335 9305 -30
- Partials 1851 1878 +27 ☔ View full report in Codecov by Sentry. |
`object_store` invokes `get_credential` on _every_ invocation of a get/list/put/etc. The provider invocation for environment based credentials is practically zero-cost, so this has no/low overhead. In the case of the AssumeRoleProvider or any provider which has _some_ cost, such as an invocation of the AWS STS APIs, this can result in rate-limiting or service quota exhaustion. In order to prevent this, the credentials are attempted to be cached only so long as they have no expired, which is defined in the `aws_credential_types::Credential` struct Signed-off-by: R. Tyler Croy <[email protected]> Sponsored-by: Scribd Inc
rtyler
force-pushed
the
credential-caching
branch
from
6a34e23
to
64d7eca
Compare
rtyler
requested review from
wjones127,
roeap,
hntd187 and
ion-elgreco
as code owners
hntd187
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
object_storeinvokesget_credentialon every invocation of a get/list/put/etc. The provider invocation for environment based credentials is practically zero-cost, so this has no/low overhead.In the case of the AssumeRoleProvider or any provider which has some cost, such as an invocation of the AWS STS APIs, this can result in rate-limiting or service quota exhaustion.
In order to prevent this, the credentials are attempted to be cached only so long as they have no expired, which is defined in the
aws_credential_types::CredentialstructSponsored-by: Scribd Inc