chore: fix many warnings across the codebase #2955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hntd187
requested review from
wjones127,
roeap,
rtyler and
ion-elgreco
as code owners
…lic methods that weren't being used anywhere Signed-off-by: Stephen Carman <[email protected]>
Signed-off-by: Stephen Carman <[email protected]>
hntd187
force-pushed
the
Chore/fix-warnings
branch
from
946a6c4
to
84cf623
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2955 +/- ##
==========================================
- Coverage 72.26% 72.21% -0.05%
==========================================
Files 131 128 -3
Lines 40660 40329 -331
Branches 40660 40329 -331
==========================================
- Hits 29382 29124 -258
+ Misses 9394 9348 -46
+ Partials 1884 1857 -27 ☔ View full report in Codecov by Sentry. |
rtyler
reviewed
Oct 23, 2024
crates/aws/src/constants.rs
Outdated
Comment on lines
102
to
103
| AWS_S3_ASSUME_ROLE_ARN, | ||
| AWS_S3_ROLE_SESSION_NAME, |
There was a problem hiding this comment.
I mentioned to @hntd187 in Slack that I would like to avoid removing these deprecation warnings until we have a few more releases which is print deprecation warnings for people
Signed-off-by: Stephen Carman <[email protected]>
rtyler
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed a lot of warnings across the codebase according to clippy and
cargo checkthe S3 options one is the only one I am not 100% sure is correct, but @rtyler maybe you can comment on if it's a good idea to remove the deprecated key usages. Otherwise I can revert those.Related Issue(s)
Closes my own internal OCD about warnings (despite there still being one)