Skip to content

Commit

Permalink
fix: upgrade python ABI to 3.9 from 3.8
Browse files Browse the repository at this point in the history
The release of pyo3 0.22.3 compells this since we cannot otherwise
compile. The choice is between pinning 0.22.2 and upgrading our ABI, and
I think it's better to upgrade the ABI
  • Loading branch information
rtyler committed Sep 20, 2024
1 parent 5fcfac5 commit 8db59c2
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
2 changes: 1 addition & 1 deletion python/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ deltalake-mount = { path = "../crates/mount" }

[dependencies.pyo3]
version = "0.22.2"
features = ["extension-module", "abi3", "abi3-py38"]
features = ["extension-module", "abi3", "abi3-py39"]

[dependencies.deltalake]
path = "../crates/deltalake"
Expand Down
3 changes: 2 additions & 1 deletion python/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1417,7 +1417,8 @@ fn scalar_to_py<'py>(value: &Scalar, py_date: &Bound<'py, PyAny>) -> PyResult<Bo
py_struct.set_item(field.name(), scalar_to_py(value, py_date)?)?;
}
py_struct.to_object(py)
}
},
Array(val) => todo!("how should this be converted!"),
};

Ok(val.into_bound(py))
Expand Down

0 comments on commit 8db59c2

Please sign in to comment.