Feat/add external integration skill #504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NeoIsALie
requested changes
Jul 3, 2023
dilyararimovna
requested changes
Jul 3, 2023
services/external_fake_server/service_configs/external-fake-service/service.yml
Outdated
Show resolved
Hide resolved
services/external_fake_server/service_configs/external-fake-service/service.yml
Outdated
Show resolved
Hide resolved
skills/external_integration_skill/service_configs/external-integration-skill/service.yml
Outdated
Show resolved
Hide resolved
skills/external_integration_skill/service_configs/external-integration-skill/environment.yml
Show resolved
Hide resolved
dilyararimovna
requested changes
Aug 6, 2023
| EXTERNAL_SKILL_URL = getenv("EXTERNAL_SKILL_URL", None) | ||
| PAYLOAD_ARGUMENT_NAME = getenv("PAYLOAD_ARGUMENT_NAME") | ||
| if not PAYLOAD_ARGUMENT_NAME: | ||
| PAYLOAD_ARGUMENT_NAME = "payload" |
There was a problem hiding this comment.
PAYLOAD_ARGUMENT_NAME = getenv("PAYLOAD_ARGUMENT_NAME", "payload")
| if not RESPONSE_KEY: | ||
| RESPONSE_KEY = "response" | ||
|
|
||
| assert "EXTERNAL_SKILL_URL", logger.info("You need to provide the external skill url to get its responses.") |
There was a problem hiding this comment.
probably it is better to raise logger.error
| confidence = 0.0 | ||
| responses.append(response) | ||
| confidences.append(confidence) | ||
| logger.info(f"Responses: {str(responses)}, confidences: {str(confidences)}") |
There was a problem hiding this comment.
those logs are will be repeated for every element of the batch
| ARGUMENTS_TO_SEND: dialog_id | ||
| PAYLOAD_ARGUMENT_NAME: payload | ||
| RESPONSE_KEY: response | ||
| REQUEST_TIMEOUT: 10 |
There was a problem hiding this comment.
параметры здесь не соответствуют тем, что в карточке в environment.yml
| REQUEST_TIMEOUT: 10 | ||
| context: . | ||
| dockerfile: ./skills/external_integration_skill/Dockerfile | ||
| command: gunicorn --workers=1 server:app -b 0.0.0.0:$8183 --timeout=300 |
oserikov
pushed a commit
that referenced
this pull request
Nov 21, 2024
* dff_external_integration_skill first commit * added yml files; added formatter * draft of external integration skill * fake external server * server filez * wip * working version of fake server/skill; tests * text fix * update ymls and fix some bugs * change port * style * revert unnecessary changes * update acc to review * ports and comments n2 * fixes * style * style * formatter * external service timeout * revert accidential change * fixes for Dilya * flake8 fix! * fix old port in readme
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.