Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignoring files/directories starting with Lib in the deps directory #5574

Closed

Conversation

BariumOxide13716
Copy link
Collaborator

@BariumOxide13716 BariumOxide13716 commented Nov 22, 2024

Reminder

  • Have you linked an issue with this pull request?
  • Have you added adequate unit tests and/or case tests for your pull request?
  • Have you noticed possible changes of behavior below or in the linked issue?
  • Have you explained the changes of codes in core modules of ESolver, HSolver, ElecState, Hamilt, Operator or Psi? (ignore if not applicable)

@mohanchen @PeizeLin
Please reject this pull request if it is unreasonable to introduce the following change:
In an earlier commit (two weeks ago) the LibComm and LibRI directories in path/to/abacus/deps are discarded. So I told the .gitignore file to ignore files/directories starting with 'Lib' in deps.

Linked Issue

Fix #...

Unit Tests and/or Case Tests for my changes

  • A unit test is added for each new feature or bug fix.

What's changed?

  • Example: My changes might affect the performance of the application under certain conditions, and I have tested the impact on various scenarios...

Any changes of core modules? (ignore if not applicable)

  • Example: I have added a new virtual function in the esolver base class in order to ...

@mohanchen
Copy link
Collaborator

I am not familiar with these codes, @PeizeLin could you review it?

@mohanchen mohanchen added Compile & CICD & Docs & Dependencies Issues related to compiling ABACUS EXX and lr-TDDFT Related to EXX or lr-TDDFT labels Nov 23, 2024
@linpeize
Copy link

deps/LibRI and deps/LibComm have been deleted. What's the purpose of adding this ignore?

@BariumOxide13716
Copy link
Collaborator Author

deps/LibRI and deps/LibComm have been deleted. What's the purpose of adding this ignore?

I am not fully aware of the howLibRI or LibComm directories will be used in the future abacus compilation. If they, or some other files whose name starts with Lib, will be downloaded when abacus is compiled for some purpose and is to be merged to the develop branch, we may tell git to ignore these files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Compile & CICD & Docs & Dependencies Issues related to compiling ABACUS EXX and lr-TDDFT Related to EXX or lr-TDDFT
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants