Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

just for test, please NOT merge !!!! replaced the atomlink with the STL. #5565

Closed
wants to merge 13 commits into from

Conversation

goodchong
Copy link
Collaborator

After a whole day of struggling with complex data structures, I am not confident in this code. I need to use the test system to check if there are any obvious bugs in the code.
The code still needs careful review and modification to meet the merge standard.
So please do NOT merge!

What's changed?

  • A highly aggressive change: replaced the original atomlink data structure with the Standard Template Library.

Any changes of core modules? (ignore if not applicable)

  • neighbor atom search

@caic99 caic99 marked this pull request as draft November 21, 2024 12:53
@mohanchen
Copy link
Collaborator

Reopen it if you need it.

@mohanchen mohanchen closed this Nov 26, 2024
@goodchong goodchong reopened this Nov 28, 2024
@goodchong goodchong closed this Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants