Refactor:Remove the dependency of the Psi in the FFT module #5564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A-006
changed the title
mohanchen
reviewed
Nov 22, 2024
| return "<unknown>"; | ||
| } | ||
|
|
||
| #define CHECK_CUFFT(func) \ |
There was a problem hiding this comment.
why there are several '' exist in the code?
There was a problem hiding this comment.
The code in this section is only called in module_fft. Would splitting check_func make it easier to maintain?
There was a problem hiding this comment.
It doesn't make any sense.
There was a problem hiding this comment.
Okay, this part has been reverted.
mohanchen
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unit Tests and/or Case Tests for my changes
What's changed?