Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: support lmax of orbital 8,9 #5528

Merged
merged 3 commits into from
Nov 20, 2024
Merged

Conversation

QuantumMisaka
Copy link
Collaborator

Reminder

  • Have you linked an issue with this pull request?
  • Have you added adequate unit tests and/or case tests for your pull request?
  • Have you noticed possible changes of behavior below or in the linked issue?
  • Have you explained the changes of codes in core modules of ESolver, HSolver, ElecState, Hamilt, Operator or Psi? (ignore if not applicable)

Linked Issue

Supplement for #5507

Unit Tests and/or Case Tests for my changes

  • A unit test is added for each new feature or bug fix.

What's changed?

  • Example: My changes might affect the performance of the application under certain conditions, and I have tested the impact on various scenarios...

Any changes of core modules? (ignore if not applicable)

  • Example: I have added a new virtual function in the esolver base class in order to ...

@kirk0830
Copy link
Collaborator

there is a PR by me needed to merge to @QuantumMisaka's lmax9 branch, please wait till my PR is merged

Enhance: throw with information when there are unexpected spetrum symbol
@kirk0830
Copy link
Collaborator

this PR is mainly completed by @QuantumMisaka, I add minor throw information suggested by @hebrewsnabla.
Thanks for all your contribution!

@mohanchen mohanchen merged commit 0ecfbc4 into deepmodeling:develop Nov 20, 2024
14 checks passed
@mohanchen mohanchen added the Refactor Refactor ABACUS codes label Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Refactor Refactor ABACUS codes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants