Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add speaker to the paragraph object #138

Merged
merged 1 commit into from
Sep 18, 2023
Merged

Conversation

DamienDeepgram
Copy link
Contributor

Resolves
#137

@jpvajda
Copy link
Contributor

jpvajda commented Sep 18, 2023

@DamienDeepgram Thanks for this PR, how did you test this? I noticed all the tests were skipped in CI. I'm not sure what to make of that.

 Deepgram.Tests -> /home/runner/work/deepgram-dotnet-sdk/deepgram-dotnet-sdk/Deepgram.Tests/bin/Debug/net7.0/Deepgram.Tests.dll
Test run for /home/runner/work/deepgram-dotnet-sdk/deepgram-dotnet-sdk/Deepgram.Tests/bin/Debug/net7.0/Deepgram.Tests.dll (.NETCoreApp,Version=v7.0)
Microsoft (R) Test Execution Command Line Tool Version 17.7.1 (x64)
Copyright (c) Microsoft Corporation.  All rights reserved.

Starting test execution, please wait...
A total of 1 test files matched the specified pattern.

Passed!  - Failed:     0, Passed:    69, Skipped:     0, Total:    69, Duration: 3 s - Deepgram.Tests.dll (net7.0)
Deepgram.Tests -> /home/runner/work/deepgram-dotnet-sdk/deepgram-dotnet-sdk/Deepgram.Tests/bin/Debug/net7.0/Deepgram.Tests.dll
Test run for /home/runner/work/deepgram-dotnet-sdk/deepgram-dotnet-sdk/Deepgram.Tests/bin/Debug/net7.0/Deepgram.Tests.dll (.NETCoreApp,Version=v7.0)
Microsoft (R) Test Execution Command Line Tool Version 17.7.0-preview-23364-03+bc17bb9693cfc4778ded51aa0ab7f1065433f989 (x64)
Copyright (c) Microsoft Corporation.  All rights reserved.

Starting test execution, please wait...
A total of 1 test files matched the specified pattern.

Passed!  - Failed:     0, Passed:    69, Skipped:     0, Total:    69, Duration: 2 s - Deepgram.Tests.dll (net7.0)

@jpvajda
Copy link
Contributor

jpvajda commented Sep 18, 2023

Let's not merge until we confirm this has been tested.

@DamienDeepgram
Copy link
Contributor Author

I tested this change to confirm it works but I have no idea why all the tests were skipped.

Do the tests usually run? The last PR also had all tests skipped it seems
https://github.com/deepgram/deepgram-dotnet-sdk/actions/runs/6150786086/job/16689477849?pr=132

@DamienDeepgram
Copy link
Contributor Author

Oh I misread the test results all 69 passed

image

@jpvajda
Copy link
Contributor

jpvajda commented Sep 18, 2023

@DamienDeepgram oh yes that comma.. 🤣 I mis-read those test results as well. This LGTM now.

@jpvajda jpvajda merged commit a33a2b5 into main Sep 18, 2023
3 checks passed
@jpvajda jpvajda deleted the fix-missing-speaker-in-paragraph branch September 18, 2023 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants