Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add conventional commit check with Husky.NET #125

Closed
wants to merge 2 commits into from

Conversation

Weimw
Copy link

@Weimw Weimw commented Aug 29, 2023

To finish setup, run dotnet husky install

@davidvonthenen
Copy link
Contributor

I took a look at this as well. I think this could be interesting; I think with many AI Tools out there (like CodeRabbit), things like this aren't really needed. The AI tools for PR analysis will perform a summary and give you a file-by-file and line-by-line analysis of what the PR is doing with shockingly great detail.

This also duplicates the entire concept of issue labels. For every PR, we should have an issue detailing what the overall change is, and that issue should contain the labels capturing bugs, chores, etc. If we want to put effort into improving the classification of what a PR is doing, we should put more effort into improving that process, plus the labels. The labels have more benefits because they don't require text parsing, and the GitHub API provides a mechanism to query labels.

@jpvajda
Copy link
Contributor

jpvajda commented May 20, 2024

Closing as we aren't taking this approach.

@jpvajda jpvajda closed this May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants