Added separate ItemGroup for target frameworks. #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dentials property in DeepgramClient. Disabled CS1998 warning in mock handler.
Added separate ItemGroup for target frameworks. Removed redundant Credentials property in DeepgramClient. Disabled CS1998 warning in mock handler.
|
I agree with @CopperBeardy - changes look good and will fix the issue. |
SandraRodgers
approved these changes
Sep 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regarding #117, submitting changes to break out the ItemGroups in .csproj by target frameworks.
Also, when building the project, I noticed the redundant private Credentials property in DeepgramClient, which was giving a warning. Removed the private property, so it uses the public one in BaseClient.
Disabled CS1998 warning in mock handler in tests as well.
Saw there were a bunch of warnings about deprecations in tests, but didn't touch those.