-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A customer reported that it's not possible to set the HTTP Timeout at all now. #127
Comments
@ThindalTV this appears to be related to your last change on timeouts. Any chance you could take a look at it? |
I tested by setting a 1 second timeout and a large 180mb MP3 file and the request did not timeout so it seems that something is not quite right |
It is most probably a bug as the 100s timeout is the default value for the timeout. I will take a look. |
I am having this same issue, SetHttpClientTimeout just doesn't take effect. Update: |
The team discussed this and in our next major release of the .NET SDK this issue will be addressed. |
Refactored the AbstractRestClient so that it can either accept a HttpClient or a IHttpClientFactory. if a HttpClient is passed in it is stored in the parameter ExternalHttpClient. During a Rest call the methods will checker wheter a HttpClient or a IHttpClientFactory is present then assign or create HttpClient that will make the rest call, this allows for a timeout to be set at anytime. this will address both issues - Timeout -#127 Socket Exhaustion - #148
Thank you! This helped me fix this bug for now, see this pull request #179 and this branch in my fork. |
This PR #207 has been merged and released |
When they try to set it to 300 it times out at 100
Error:
Originally posted by @DamienDeepgram in #116 (comment)
The text was updated successfully, but these errors were encountered: