Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bunch of small fixes #337

Merged
merged 3 commits into from
Nov 17, 2024
Merged

Bunch of small fixes #337

merged 3 commits into from
Nov 17, 2024

Conversation

nemunaire
Copy link
Collaborator

I'm cleaning up some patches I made some time ago...

  1. In order to let some email clients/servers to sort properly by date, the email sent by rmfakecloud needs to be dated. This adds a Date header.
  2. Some missing returns after AbortWithStatus.
  3. PUT /sync/v3/files/ doesn't have body on success, nor crc32c:
$ curl -v -s -X PUT -d @file -H "x-goog-hash: crc32c=123456==" -H "Authorization: Bearer $USER_TOKEN" https://internal.cloud.remarkable.com/sync/v3/files/REDACTED
* Connected to internal.cloud.remarkable.com (34.117.147.117) port 443
> PUT /sync/v3/files/REDACTED HTTP/2
> Host: internal.cloud.remarkable.com
> x-goog-hash: crc32c=123456==
> Authorization: Bearer redacted
> Content-Length: 123
>
* upload completely sent off: 123 bytes
< HTTP/2 200
< rm-token-ttl-hint: 9876
< content-length: 0
< date: Sun, 12 Jan 2024 12:34:45 GMT
< server: Google Frontend
< x-cloud-trace-context: redacted;o=1
< traceparent: redacted
< content-type: text/html; charset=UTF-8
< x-envoy-decorator-operation: ingress PutFile
< via: 1.1 google
< alt-svc: h3=":443"; ma=2592000,h3-29=":443"; ma=2592000
<
* Connection #0 to host internal.cloud.remarkable.com left intact

@ddvk ddvk merged commit cb1e4ea into ddvk:master Nov 17, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants