-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 14 add from cms #62
Merged
andrew-c-tran
merged 22 commits into
ddev:master
from
andrew-c-tran:issue_14_add_from_cms
Jan 2, 2018
Merged
Changes from 7 commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
2e8989a
[AT] - WIP initial commit - add from cms working.
andrew-c-tran c204047
[AT] - WIP initial commit - add from cms working.
andrew-c-tran 7e2cb1e
[AT] - WIP - updated add flow
andrew-c-tran dd1f72c
[AT] - WIP - restored accidentally removed spinner
andrew-c-tran cea41fe
[AT] - visual updates to accordions
andrew-c-tran b3d71d3
[AT] - added JSDOC comments to functions
andrew-c-tran 48de384
[AT] - added full tests
andrew-c-tran 942d1ea
[AT] - wip - pull notes fix
andrew-c-tran fcfd443
[AT] - added handling for tarball missing error, unpacked files to ro…
andrew-c-tran 9f83ba0
[AT] - updated completion messaging
andrew-c-tran 0cb990e
[AT] - updated error screen styles, added support for no router running
andrew-c-tran dbc04d0
[AT] - updated error screen styles, added support for no router running
andrew-c-tran d11941e
[AT] - removed inline styles, moved modals from static markup in inde…
andrew-c-tran f4a89e6
[AT] - flattened "promise pyramid"
andrew-c-tran 38654f5
[AT] - updated no sites detection
andrew-c-tran da57ba9
[AT] - updated to use fs.mkdir for cross platform compatability
andrew-c-tran 56f581f
[AT] - added JSDOC documentation to ddev-shell.js and added dev-env d…
andrew-c-tran 4b1ffc0
[AT] - module extraction, added JSDOC comments for ALL code, made lif…
andrew-c-tran 40bd0b1
[AT] - updated comment and company name
andrew-c-tran 468da71
[AT] - updated test comments
andrew-c-tran 7ccbdf6
[AT] - addressed several feedback changes
andrew-c-tran d6f61aa
[AT] - fixed tests
andrew-c-tran File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess I would expect this to be in the js application and not in the index.html?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed modals and created a createModal template that programmatically generates and injects modals into the DOM.