Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport New Snapshot Configuration to 1.9.latest #11037

Open
wants to merge 1 commit into
base: 1.9.latest
Choose a base branch
from
Open

Backport New Snapshot Configuration to 1.9.latest #11037

wants to merge 1 commit into from

Conversation

peterallenwebb
Copy link
Contributor

Checklist

  • I have read the contributing guide and understand what's expected of me.
  • I have run this code in development, and it appears to resolve the stated issue.
  • This PR includes tests, or tests are not required or relevant for this PR.
  • This PR has no interface changes (e.g., macros, CLI, logs, JSON artifacts, config files, adapter interface, etc.) or this PR has already received feedback and approval from Product or DX.
  • This PR includes type annotations for new and modified functions.

@peterallenwebb
Add New Config Properties and Schema for Snapshot Hard Deletes (#10972)
6d2eea4 
* Add changelog entry.

* Update schemas and test fixtures for new snapshot meta-column

* Add back comment.
@peterallenwebb peterallenwebb requested review from a team as code owners November 22, 2024 20:16
@peterallenwebb peterallenwebb requested review from PaulVPham and removed request for a team November 22, 2024 20:16
@peterallenwebb peterallenwebb added the artifact_minor_upgrade To bypass the CI check by confirming that the change is not breaking label Nov 22, 2024
@codecov Codecov
Copy link

codecov bot commented Nov 22, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.10%. Comparing base (bda92e7) to head (6d2eea4).

Additional details and impacted files 
@@              Coverage Diff               @@
##           1.9.latest   #11037      +/-   ##
==============================================
- Coverage       89.15%   89.10%   -0.05%     
==============================================
  Files             183      183              
  Lines           23764    23765       +1     
==============================================
- Hits            21186    21176      -10     
- Misses           2578     2589      +11
Flag Coverage Δ
integration 86.41% <100.00%> (-0.11%) ⬇️
unit 62.17% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
Unit Tests 62.17% <100.00%> (+<0.01%) ⬆️
Integration Tests 86.41% <100.00%> (-0.11%) ⬇️
---- 🚨 Try these New Features:

@peterallenwebb peterallenwebb added artifact_minor_upgrade To bypass the CI check by confirming that the change is not breaking and removed artifact_minor_upgrade To bypass the CI check by confirming that the change is not breaking labels Nov 22, 2024
@peterallenwebb peterallenwebb added artifact_minor_upgrade To bypass the CI check by confirming that the change is not breaking and removed artifact_minor_upgrade To bypass the CI check by confirming that the change is not breaking labels Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@graciegoheen graciegoheen graciegoheen approved these changes

@MichelleArk MichelleArk MichelleArk approved these changes

@gshank gshank gshank approved these changes

@PaulVPham PaulVPham Awaiting requested review from PaulVPham PaulVPham is a code owner automatically assigned from dbt-labs/cloud-artifacts

Assignees
No one assigned
Labels
artifact_minor_upgrade To bypass the CI check by confirming that the change is not breaking
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@peterallenwebb @gshank @MichelleArk @graciegoheen