Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update core to support DSI 0.8.1 #10990

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Update core to support DSI 0.8.1 #10990

wants to merge 4 commits into from

Conversation

WilliamDee
Copy link
Contributor

@WilliamDee WilliamDee commented Nov 12, 2024 •
edited
Loading

Problem

Upgrade to DSI 0.8.0 to support passing custom time grain in the yaml spec

schema change PR: dbt-labs/schemas.getdbt.com#70

Solution

Checklist

  • I have read the contributing guide and understand what's expected of me.
  • I have run this code in development, and it appears to resolve the stated issue.
  • This PR includes tests, or tests are not required or relevant for this PR.
  • This PR has no interface changes (e.g., macros, CLI, logs, JSON artifacts, config files, adapter interface, etc.) or this PR has already received feedback and approval from Product or DX.
  • This PR includes type annotations for new and modified functions.

@WilliamDee WilliamDee requested review from a team as code owners November 12, 2024 21:36
@WilliamDee WilliamDee requested review from wpowers-dbt and removed request for a team November 12, 2024 21:36
@cla-bot cla-bot bot added the cla:yes label Nov 12, 2024
@github-actions GitHub Actions
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@github-actions github-actions bot added the community This PR is from a community member label Nov 12, 2024
@codecov Codecov
Copy link

codecov bot commented Nov 12, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 95.65217% with 1 line in your changes missing coverage. Please review.

Project coverage is 89.07%. Comparing base (89caa33) to head (0256834).
Report is 6 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #10990      +/-   ##
==========================================
- Coverage   89.10%   89.07%   -0.03%     
==========================================
  Files         183      183              
  Lines       23626    23627       +1     
==========================================
- Hits        21051    21046       -5     
- Misses       2575     2581       +6
Flag Coverage Δ
integration 86.37% <86.95%> (-0.03%) ⬇️
unit 62.82% <86.95%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
Unit Tests 62.82% <86.95%> (+0.03%) ⬆️
Integration Tests 86.37% <86.95%> (-0.03%) ⬇️

@WilliamDee WilliamDee changed the title Update to DSI 0.8.0 Update to DSI 0.8.1 Nov 12, 2024
@WilliamDee WilliamDee changed the title Update to DSI 0.8.1 Update core to support DSI 0.8.1 Nov 12, 2024
QMalcolm
QMalcolm reviewed Nov 14, 2024
View reviewed changes
Copy link
Contributor

@QMalcolm QMalcolm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! I had one question about MFs/DSIs expectations on case. Depending on the answer to that, we might need to make changes, or we might just be good to go 🙂

core/dbt/artifacts/resources/v1/semantic_model.py Show resolved Hide resolved
core/dbt/artifacts/resources/v1/metric.py Show resolved Hide resolved
core/dbt/artifacts/resources/v1/metric.py Show resolved Hide resolved
core/dbt/parser/schema_yaml_readers.py
def _get_optional_time_window(
self, unparsed_window: Optional[str]
) -> Optional[MetricTimeWindow]:
if unparsed_window is not None:
parts = unparsed_window.split(" ")
parts = unparsed_window.lower().split(" ")
Copy link
Contributor

@QMalcolm QMalcolm Nov 14, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does DSI/Metricflow require these be lowercase now? If so, this may be breaking as for already parsed manifests 🤔

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope! It should not be case sensitive. This is lowercasing it before we get it so that the user doesn't need to worry about lowercasing it but we can expect lowercase on our side. Will added tests for case sensitivity in DSI, too.

Copy link
Contributor

@QMalcolm QMalcolm Nov 15, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The words that concern me are

but we can expect lowercase on our side

I'm not sure you can unfortunately, but I could be wrong about that. Could you point me to the tests around case sensitivity in DSI?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep!
https://github.com/dbt-labs/dbt-semantic-interfaces/blob/f3a50f02b962ce7193b801784740e244057ddb69/tests/parsing/test_metric_parsing.py#L215-L216
and
https://github.com/dbt-labs/dbt-semantic-interfaces/blob/f3a50f02b962ce7193b801784740e244057ddb69/tests/parsing/test_metric_parsing.py#L240-L241

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me go back and make sure all other fields have this covered, too

@QMalcolm QMalcolm added the artifact_minor_upgrade To bypass the CI check by confirming that the change is not breaking label Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QMalcolm QMalcolm QMalcolm left review comments

@wpowers-dbt wpowers-dbt Awaiting requested review from wpowers-dbt wpowers-dbt is a code owner automatically assigned from dbt-labs/cloud-artifacts

@courtneyholcomb courtneyholcomb Awaiting requested review from courtneyholcomb

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
artifact_minor_upgrade To bypass the CI check by confirming that the change is not breaking cla:yes community This PR is from a community member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@WilliamDee @QMalcolm @courtneyholcomb