CB-5125 do not trigger logo in configuration stage #3096
Conversation
There was a problem hiding this comment.
plugin-top-bar-app cannot use the administration package, it's better to branch out from CB-5918 and make changes in plugin-app-logo-administration
| return <AppLogo title={title} onClick={() => screenService.navigateToRoot()} />; | ||
| return <AppLogo title={title} onClick={administrationScreenService.isConfigurationMode ? undefined : () => screenService.navigateToRoot()} />; |
There was a problem hiding this comment.
it's better to fix somehow in ScreenService or in AppScreenBootstrap (so basically we need to block public screen activation in case we in configuration mode (we can check it from server config for not administration pages))
There was a problem hiding this comment.
Plugins can use any core* packages.
I am not sure about adding this logic to the screen service. It should not check itself whether it can be navigate or not, it should be checked outside of this service. Cause screen service has single responsibility, we want to keep it this way
No description provided.