Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some hacking around visual, shell and collectionview #59

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

DamianAntonowicz
Copy link

Hi 👋

This is quick & dirty implementation of https://www.wykop.pl/ (polish website similar to reddit) mobile app and I've used Visual, Shell and CollectionView to build it.

Below are some screenshots. First on the left is original app on iPhone, second is my implementation on Android and the last one is my implementation on iPhone.

MainPage

Flyout

LoginPage

Feedback

What went well:

  • it's super easy to setup hamburger menu
  • easy to setup navigation between views from hamburger menu
  • easy to style Button to look the same on both platforms

What didn't went well / wish list:

  • I've been struggling to display hamburger icon on iOS until I find out this bug: [Shell] 3bar.png missing for the flyout menu hamburger xamarin/Xamarin.Forms#3124 icon should display out of the box
  • I would like to add custom content to Flyout like copyright label
  • ShellItem is missing BackgroundColor - now I need to use Shell.ItemTemplate to change background color
  • ShellItem could have Margin property for better control items in menu
  • it would be nice to have possibility to set different template for each ShellItem
  • I've been struggling with difference between FlyoutItem vs ShellItem and Tab vs ShellSection. Documentation: https://docs.microsoft.com/en-us/xamarin/xamarin-forms/app-fundamentals/shell doesn't say anything about FlyoutItem and Tab
  • setting HeightRequest on container inside Shell.ItemTemplate is not respected by iOS. However it works on Android
  • it could be nice to have radius property on Image control
  • also it could be nice if we can load embedded image from shared project without need to have custom markup extension like ImageResourceExtension from Gastropods sample
  • adding items ToolbarItems on the left could be useful. I would like to place there a cancel button. Now I can place ToolbarItems only on the right
  • Entry don't have properties to set border color, placeholder behavior (animate or not)

Hope you will find this useful.

@PureWeen
Copy link
Contributor

@DamianAntonowicz this is awesome thank you!!

I've been struggling with difference between FlyoutItem vs ShellItem and Tab vs ShellSection.

That's us playing with naming. We found that people were confused about ShellItem and ShellSection so we just aliased them to something else that's more indicative of what they do.

at this point FlyoutItem is equivalent to ShellItem and Tab is equivalent to ShellSection.

If they were just called FlyoutItem and Tab would those names make sense to you in the context of building up your Shell?

@DamianAntonowicz
Copy link
Author

@PureWeen FlyoutItem and Tab makes more sense for me. However those names needs to be used consistently across documentation and code samples (Gastropods, Tailwind).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants