Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CNDB-11782: additional messaging metrics #1426

Merged
merged 1 commit into from
Nov 25, 2024

Conversation

jakubzytka
Copy link

@jakubzytka jakubzytka commented Nov 18, 2024

New message-oriented metrics: node message handling time (per message type), and time spent by each message handler on the relevant stage (again per message type)

What is the issue

The isssue is lack of visibility into how much time nodes actually spend handling messages.
So far, we only had cross-node metrics.

What does this PR fix and why was it fixed

This PR adds two additional metrics:

  • node total (queue+execution) message handling time
  • execution time of the message handler in the relevant stage

Checklist before you submit for review

  • Make sure there is a PR in the CNDB project updating the Converged Cassandra version
  • Use NoSpamLogger for log lines that may appear frequently in the logs
  • Verify test results on Butler
  • Test coverage for new/modified code is > 80%
  • Proper code formatting
  • Proper title for each commit staring with the project-issue number, like CNDB-1234
  • Each commit has a meaningful description
  • Each commit is not very long and contains related changes
  • Renames, moves and reformatting are in distinct commits

@jakubzytka jakubzytka force-pushed the cndb-11782-messaging-metrics branch 2 times, most recently from 3e7908e to ab37ca7 Compare November 18, 2024 17:53
New message-oriented metrics: node message handling time (per message type), and time spent by each message handler on the relevant stage (again per message type)
Copy link

sonarcloud bot commented Nov 25, 2024

@cassci-bot
Copy link

❌ Build ds-cassandra-pr-gate/PR-1426 rejected by Butler


1 new test failure(s) in 3 builds
See build details here


Found 1 new test failures

Test Explanation Branch history Upstream history
...et=list,wide=false,scenario=SSTABLE_QUERY] flaky 🔵🔴🔵 🔵🔵🔵🔵🔵🔵🔵

Found 13 known test failures

@jakubzytka jakubzytka merged commit 76037f0 into main Nov 25, 2024
460 of 474 checks passed
@jakubzytka jakubzytka deleted the cndb-11782-messaging-metrics branch November 25, 2024 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants