Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tutorials #01 and #02 #36

Merged
merged 89 commits into from
Oct 12, 2023
Merged

Conversation

MilagrosMarin
Copy link
Collaborator

@MilagrosMarin MilagrosMarin commented Sep 18, 2023

The following tasks have been completed by merging this Pull Request:

  • Update tutorial 01-DataJoint Basics.ipynb
  • Update tutorial 02-Calcium Imaging Imported Tables.ipynb

@MilagrosMarin MilagrosMarin added the documentation Improvements or additions to documentation label Sep 25, 2023
@MilagrosMarin MilagrosMarin self-assigned this Sep 25, 2023
Copy link
Collaborator

@kushalbakshi kushalbakshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @MilagrosMarin. I've included a few suggested changes below. Given the length of these notebooks, and the importance of these tutorials, it will likely be a few days of review before we're ready to merge.

tutorials/01-DataJoint Basics.ipynb Outdated Show resolved Hide resolved
tutorials/01-DataJoint Basics.ipynb Outdated Show resolved Hide resolved
tutorials/01-DataJoint Basics.ipynb Outdated Show resolved Hide resolved
tutorials/01-DataJoint Basics.ipynb Outdated Show resolved Hide resolved
tutorials/01-DataJoint Basics.ipynb Outdated Show resolved Hide resolved
tutorials/01-DataJoint Basics.ipynb Outdated Show resolved Hide resolved
tutorials/01-DataJoint Basics.ipynb Outdated Show resolved Hide resolved
tutorials/01-DataJoint Basics.ipynb Outdated Show resolved Hide resolved
tutorials/01-DataJoint Basics.ipynb Outdated Show resolved Hide resolved
tutorials/01-DataJoint Basics.ipynb Outdated Show resolved Hide resolved
@kushalbakshi kushalbakshi removed the request for review from kabilar September 26, 2023 13:59
@MilagrosMarin MilagrosMarin linked an issue Sep 26, 2023 that may be closed by this pull request
kushalbakshi and others added 17 commits October 5, 2023 11:34
Minor markdown changes for clarity
Copy link
Collaborator

@kushalbakshi kushalbakshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for reinserting the changes @MilagrosMarin. Some of these changes were either missed or did not make it into this round. I'll be issuing a PR to your fork shortly to correct this. Once that PR is merged, I will verify that the notebooks run in Codespaces before merging all of these changes into the main repository.

Copy link
Collaborator

@kushalbakshi kushalbakshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you for your work on this @MilagrosMarin.

@kushalbakshi kushalbakshi merged commit 90481f1 into datajoint:main Oct 12, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Improve notebooks for clarity
3 participants