Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(java-sdk): custom properties patch client #11984

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

shirshanka
Copy link
Contributor

  • Fixes an issue with the custom properties patch client in Java where if custom properties are the only things being changed, the parent patcher assumes there are no patches and throws an exception on build().
  • Changes the interaction model between the parent patch builder and the inner builder. The inner builder now directly adds to the parent's "operations list".

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@yoonhyejin yoonhyejin requested review from yoonhyejin and removed request for RyanHolstien November 28, 2024 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants