Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): added cli option for ingestion source #11980

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kevinkarchacryl
Copy link
Contributor

@kevinkarchacryl kevinkarchacryl commented Nov 27, 2024

Rather than change the current CLI option, I decided to add a new one. This datahub ingest list-sources shows three columns: the urn, name, and total number of executions like so:
image
For reviewers:

  1. I wasn't able to find where I would change the documentation. I edited a couple of untracked documents but I think they were generated automatically.
  2. Would you keep the URN column or get rid of it? Add or remove any other columns?
  3. What are the commands for cleaning up Python files? I know we use black, isort, and flake8 but I don't know the arguments.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Nov 27, 2024
@datahub-cyborg datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ingestion PR or Issue related to the ingestion of metadata needs-review Label for PRs that need review from a maintainer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant