Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build issue #73

Merged
merged 2 commits into from
Nov 18, 2024
Merged

Fix build issue #73

merged 2 commits into from
Nov 18, 2024

Conversation

ashwinisukale
Copy link
Contributor

Purpose

closes: Add github issue that originated this PR

Approach

Open Questions and Pre-Merge TODOs

Learning

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

  • New feature (non-breaking change which adds functionality)

  • Breaking change (fix or feature that would cause existing functionality to change)

Reviewer, please remember our guidelines:

  • Be humble in the language and feedback you give, ask don't tell.
  • Consider using positive language as opposed to neutral when offering feedback. This is to avoid the negative bias that can occur with neutral language appearing negative.
  • Offer suggestions on how to improve code e.g. simplification or expanding clarity.
  • Ensure you give reasons for the changes you are proposing.

@kaysiz kaysiz changed the title revert the change as its not the cause of the problem Fix build issue Nov 18, 2024
@ashwinisukale ashwinisukale merged commit e1764e6 into master Nov 18, 2024
2 checks passed
@ashwinisukale ashwinisukale deleted the revert_fix branch November 18, 2024 12:57
@ashwinisukale ashwinisukale self-assigned this Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants