Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement ST_ASEWKT #378

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

r3stl355
Copy link
Contributor

Translates a geometry into its representation in Extended Well-known Text (EWKT) format.

Added tests and docs

@codecov
Copy link

codecov bot commented May 15, 2023

Codecov Report

Merging #378 (95b223e) into main (bb49756) will decrease coverage by 0.05%.
The diff coverage is 98.63%.

❗ Current head 95b223e differs from pull request most recent head 79b291c. Consider uploading reports for the commit 79b291c to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #378      +/-   ##
==========================================
- Coverage   94.99%   94.94%   -0.05%     
==========================================
  Files         198      198              
  Lines        5655     5718      +63     
  Branches      181      171      -10     
==========================================
+ Hits         5372     5429      +57     
- Misses        283      289       +6     
Impacted Files Coverage Δ
...cks/labs/mosaic/core/geometry/GeometryReader.scala 100.00% <ø> (ø)
...tabricks/labs/mosaic/functions/MosaicContext.scala 97.36% <90.00%> (-0.14%) ⬇️
.../labs/mosaic/codegen/format/ConvertToCodeGen.scala 90.32% <100.00%> (+0.32%) ⬆️
...c/codegen/format/MosaicGeometryIOCodeGenESRI.scala 100.00% <100.00%> (ø)
...ic/codegen/format/MosaicGeometryIOCodeGenJTS.scala 100.00% <100.00%> (ø)
...labs/mosaic/core/geometry/MosaicGeometryESRI.scala 96.82% <100.00%> (+0.13%) ⬆️
.../labs/mosaic/core/geometry/MosaicGeometryJTS.scala 97.08% <100.00%> (+0.11%) ⬆️
...ks/labs/mosaic/core/geometry/api/GeometryAPI.scala 100.00% <100.00%> (ø)
...metrycollection/MosaicGeometryCollectionESRI.scala 97.72% <100.00%> (+0.02%) ⬆️
...ometrycollection/MosaicGeometryCollectionJTS.scala 100.00% <100.00%> (ø)
... and 13 more

... and 1 file with indirect coverage changes

@r3stl355
Copy link
Contributor Author

I'll add more tests

@r3stl355
Copy link
Contributor Author

CodeCov report still shows the original commit results, last commit results can be see here and show all green: https://app.codecov.io/github/databrickslabs/mosaic/commit/95b223e4fcf8e32242d36a085dead3065453eee4

@r3stl355
Copy link
Contributor Author

cleaned up and rebased

refactor and add tests

clean up

restore ignored test
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

1 similar comment
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants