Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort before uniq to return unique ISSNs #79

Open
wants to merge 1 commit into
base: gh-pages
Choose a base branch
from

Conversation

mawds
Copy link

@mawds mawds commented Jan 19, 2018

In the exercise to count the number of unique ISSN values, uniq only matches adjacent matching lines, so the list of ISSNs should be sorted before piping to uniq.

This PR notes that uniq only works on adjacent lines, and modifies the exercise to sort the list of ISSNs before piping through uniq

@danmichaelo
Copy link
Contributor

Good catch! But note that -P is not available in BSD grep (as on Macs) :( So perhaps using number ranges [0-9] is the best cross-platform solution.

@weaverbel
Copy link

Are you able to amend the code to reflect that @danmichaelo ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants