Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: phaseplot widget, export layers to yt ds #152

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

chrishavlin
Copy link
Collaborator

This PR adds:

  • a convenience function for exporting layers loaded in napari to a uniform grid yt ds
  • a new phaseplot widget

may split those to separate prs...

@chrishavlin chrishavlin added the enhancement New feature or request label Nov 21, 2024
@chrishavlin chrishavlin marked this pull request as draft November 21, 2024 18:15
Copy link

codecov bot commented Nov 21, 2024

Codecov Report

Attention: Patch coverage is 4.23729% with 113 lines in your changes missing coverage. Please review.

Project coverage is 95.74%. Comparing base (eb16ab0) to head (2d6cd32).
Report is 16 commits behind head on main.

Files with missing lines Patch % Lines
src/yt_napari/_widget_2d_plots.py 0.00% 80 Missing ⚠️
src/yt_napari/viewer.py 9.37% 29 Missing ⚠️
src/yt_napari/_gui_utilities.py 33.33% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #152      +/-   ##
==========================================
- Coverage   99.60%   95.74%   -3.86%     
==========================================
  Files          37       38       +1     
  Lines        2799     2917     +118     
==========================================
+ Hits         2788     2793       +5     
- Misses         11      124     +113     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@chrishavlin
Copy link
Collaborator Author

chrishavlin commented Nov 21, 2024

Still needs a bunch of UI design and fixes:

  • labels (those drop downs are the PhasePlot x, y, z and weight field arguments
  • add options for the rest of the PhasePlot arguments
  • add some options for plot callbacks (log switches, colormap, etc)
  • the matplotlib figure does not rescale well with the window

but there's a figure!

Screenshot from 2024-11-21 14-43-44

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant