feat(sdk): asset lock quorum and core locked height verification #2030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lklimek
changed the title
lklimek
force-pushed
the
fix/sdk-invalid-quorum
branch
from
9c21078
to
b3f5f17
Compare
lklimek
changed the title
lklimek
changed the title
lklimek
force-pushed
the
fix/sdk-invalid-quorum
branch
from
a328081
to
f57e455
Compare
lklimek
commented
Aug 22, 2024
|
|
||
| pub fn new_devnet() -> Self { | ||
| QuorumParams { | ||
| // FIXME: local devnet uses regtest |
There was a problem hiding this comment.
This needs discussion how to handle that.
shumkov
requested changes
Aug 23, 2024
| Ok(()) | ||
| } | ||
| } | ||
| AssetLockProof::Instant(v) => { |
There was a problem hiding this comment.
It's not gonna check if we can verify signature in Drive, right?
There was a problem hiding this comment.
If you have any hint how to do that client-side, I would be happy to include this here.
There was a problem hiding this comment.
@QuantumExplorer can you give me some formula to add it here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
We want to be able to check if the platform can process an asset lock.
What was done?
Added AssetLockProofVerifier trait with verify() method, implemented on AssetLockProof.
How Has This Been Tested?
Added test.
Note: Requires #2061 to pass the tests.
Breaking Changes
None
Checklist:
For repository code-owners and collaborators only