Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Style updates for the suggestion widget. #8214

Merged
merged 2 commits into from
Nov 1, 2024
Merged

Style updates for the suggestion widget. #8214

merged 2 commits into from
Nov 1, 2024

Conversation

isoos
Copy link
Collaborator

@isoos isoos commented Oct 31, 2024

image

Deployed to staging.

@isoos isoos requested review from jonasfj and sigurdm October 31, 2024 13:59
@sigurdm
Copy link
Contributor

sigurdm commented Oct 31, 2024

Please round also the top border...

@sigurdm
Copy link
Contributor

sigurdm commented Oct 31, 2024

Highlighting the matched prefix looks a lot better to me!
Contrast looks much better

Thanks!

@isoos isoos merged commit aa0e87e into dart-lang:master Nov 1, 2024
32 checks passed
@isoos isoos deleted the suggestion-updates branch November 1, 2024 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonasfj jonasfj jonasfj approved these changes

@sigurdm sigurdm Awaiting requested review from sigurdm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@isoos @sigurdm @jonasfj